Skip to content

Attempt to fix registry-scanner for changes in dirs in opentelemetry-js-contrib.git #7290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
trentm wants to merge 1 commit into from
Closed

Attempt to fix registry-scanner for changes in dirs in opentelemetry-js-contrib.git #7290

trentm wants to merge 1 commit into from

Conversation

@trentm
Copy link
Contributor

@trentm trentm commented Jul 9, 2025

Refs: open-telemetry/opentelemetry-js-contrib#2928

@svrnm This is a first attempt. Do you use this script manually? I don't see where CI is using this anywhere. These changes don't handle packages/resource-detector-... in https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/packages properly. I wasn't sure how that was working before. When I run npm start js with my changes here, I get these new files, which isn't correct:

	resource-detector-js-resourcedetectoralibabacloud.yml
	resource-detector-js-resourcedetectoraws.yml
	resource-detector-js-resourcedetectorazure.yml
	resource-detector-js-resourcedetectorcontainer.yml
	resource-detector-js-resourcedetectorgcp.yml
	resource-detector-js-resourcedetectorgithub.yml
	resource-detector-js-resourcedetectorinstana.yml

@trentm trentm requested a review from svrnm July 9, 2025 21:45
@trentm trentm self-assigned this Jul 9, 2025
@svrnm
Copy link
Member

svrnm commented Jul 16, 2025 •
edited
Loading

yes, that scanner is run only manually and I have to admit I have not run it for a while ...

so if it works for you locally I am happy to merge it:)

@trentm
Copy link
Contributor Author

trentm commented Aug 22, 2025

so if it works for you locally

It does not work what I'd consider correctly for me locally. I'll close this PR for now. Feel free to take what's here as a start if you need this script again later.

@trentm trentm closed this Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svrnm svrnm Awaiting requested review from svrnm

Assignees

@trentm trentm

Labels

None yet

Projects

SIG Comms: PRs & Issues
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trentm @svrnm